Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#118] Replace assertEquals with assertEqual in tests (main) #120

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[#118] Replace assertEquals with assertEqual in tests (main) #120

merged 1 commit into from
Aug 6, 2024

Conversation

alanking
Copy link
Contributor

@alanking alanking commented Aug 6, 2024

Addresses #118

Cherry-picked from #119

korydraughn
korydraughn approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
[irods#118] Replace assertEquals with assertEqual in tests
eeb22ef 
unittest.assertEquals was deprecated as an alias of unittest.assertEqual
in python 3.2. The alias was removed in python 3.12. This commit replaces
the use of the deprecated / removed alias with the proper method name.
@alanking
Copy link
Contributor Author

alanking commented Aug 6, 2024

#'d. Mergin

@alanking alanking merged commit c7e9dd7 into irods:main Aug 6, 2024
1 of 2 checks passed
@alanking alanking deleted the 118.m branch August 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanking @korydraughn